Conversation
Zeroto521
requested changes
Jun 10, 2021
Member
Zeroto521
left a comment
Zeroto521
left a comment
There was a problem hiding this comment.
This pr would wait still Flow-Launcher/Flow.Launcher.JsonRPC.Python#8 finish.
Comment on lines
+14
to
+18
| def callBackMethodSample(self, **args): | ||
| action = copy.deepcopy(ACTION_TEMPLATE) | ||
| // do what you want to do | ||
|
|
||
| return message |
Member
There was a problem hiding this comment.
This function seems duplicated to sendNormalMess and sendActionMess.
And what the message variable is used to do?
| action['JsonRPCAction']['method'] = method | ||
| action['JsonRPCAction']['parameters'] = value | ||
| message.update(action) | ||
| message['JsonRPCAction'] = action; |
Member
There was a problem hiding this comment.
Is this your meaning?
# information
message = copy.deepcopy(RESULT_TEMPLATE)
message['Title'] = title
message['SubTitle'] = subtitle
# action
action = copy.deepcopy(ACTION_TEMPLATE)
action['method'] = method
action['parameters'] = value
message.update(action)
Member
Author
There was a problem hiding this comment.
yes, but I would like to change Action-Template without the wrapper, because Flow's JsonRPCRequestModel is without the wrapper. This aligns with your design that RESULT_TEMPLATE is not {result:{~~~}}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correlate to Flow-Launcher/Flow.Launcher.JsonRPC.Python#8